Repository navigation
Conversation
lukelowry
force-pushed
the
lukel/component-enable-dev
branch
2 times, most recently
from
October 6, 2026 08:29
1df5bb8 to
959899f
Compare
nkoukpaizan
added
the
development
lukelowry
force-pushed
the
lukel/component-enable-dev
branch
from
October 6, 2026 20:54
959899f to
3cb2a38
Compare
nkoukpaizan
added
new study
pelesh
requested changes
Oct 6, 2026
pelesh
left a comment
pelesh
left a comment
Collaborator
There was a problem hiding this comment.
Great work!
There is one major item that needs to be addressed and that is to identify cases when taking line out of service makes underlying linear system singular. That needs to be clearly identified in this PR, so that a remedy can be implemented subsequently.
My guess is that islanding would be one such instance. This can be easily checked with ten-gen example. There may be other instances where zeroing out branch Jacobian stamp may lead to singular system Jacobian.
@abirchfield and @shakedregev: please chime in.
The rest are nitpicking suggestions.
Co-authored-by: pelesh <peless@ornl.gov>
Co-authored-by: pelesh <peless@ornl.gov>
Co-authored-by: pelesh <peless@ornl.gov>
Collaborator
Author
|
Addressed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds solver events that take a branch in and out of service. Part 1 of #606, modern attempt of #391. This
Branchmodel is designed specifically forContingencyAnalysis, as introducing breaker and relay raises the same problem we faced withBusFault. Next PR will be a smooth breaker and relay.@pelesh
Proposed changes
Branch::setEnabled(bool), Implemented using an admittance mask on the branch equations.SystemModel::getComponent(id)looks up a branch by its case-fileid.enable/disabletake adeviceid and are handled like fault events.DynamicSimulation/Toy/ThreeBusBasic:BR_1_2opens at 1 s and recloses at 5 s.BranchTests::singularJacobian(pattern kept, values zero)Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
Repsonse